New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix LocalDate.MAX, special case for postgresql time column. Use 24:00… #992
Merged
Merged
Changes from 3 commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
e02db2a
fix LocalDate.MAX, special case for postgresql time column. Use 24:00…
davecramer 10925e3
use equals for check with LocalTime.MAX
davecramer f79efc5
change assertTrue to assertEquals
davecramer d098f56
fix checkstyle and revert assertEquals where appropriate
davecramer File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -8,11 +8,14 @@ | |
import org.postgresql.test.TestUtil; | ||
import org.postgresql.test.jdbc2.BaseTest4; | ||
|
||
import org.junit.Assert; | ||
import org.junit.Test; | ||
|
||
import java.sql.PreparedStatement; | ||
import java.sql.ResultSet; | ||
import java.sql.SQLException; | ||
import java.sql.Types; | ||
import java.time.LocalTime; | ||
|
||
|
||
public class PreparedStatementTest extends BaseTest4 { | ||
|
@@ -22,12 +25,14 @@ public void setUp() throws Exception { | |
super.setUp(); | ||
TestUtil.createTable(con, "timestamptztable", "tstz timestamptz"); | ||
TestUtil.createTable(con, "timetztable", "ttz timetz"); | ||
TestUtil.createTable(con, "timetable", "id serial, tt time"); | ||
} | ||
|
||
@Override | ||
public void tearDown() throws SQLException { | ||
TestUtil.dropTable(con, "timestamptztable"); | ||
TestUtil.dropTable(con, "timetztable"); | ||
TestUtil.dropTable(con, "timetable"); | ||
super.tearDown(); | ||
} | ||
|
||
|
@@ -60,4 +65,31 @@ public void testTimeTzSetNull() throws SQLException { | |
|
||
pstmt.close(); | ||
} | ||
|
||
@Test | ||
public void testLocalTimeMax() throws SQLException { | ||
PreparedStatement pstmt = con.prepareStatement("INSERT INTO timetable (tt) VALUES (?)"); | ||
|
||
pstmt.setObject(1, LocalTime.MAX); | ||
pstmt.executeUpdate(); | ||
|
||
pstmt.setObject(1, LocalTime.MIN); | ||
pstmt.executeUpdate(); | ||
|
||
ResultSet rs = con.createStatement().executeQuery("select tt from timetable order by id asc"); | ||
Assert.assertEquals(true, rs.next()); | ||
|
||
LocalTime localTime = (LocalTime)rs.getObject(1,LocalTime.class); | ||
|
||
|
||
Assert.assertEquals( LocalTime.MAX, localTime); | ||
|
||
Assert.assertEquals(true, rs.next()); | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The assertTrue here was fine. |
||
|
||
localTime = (LocalTime)rs.getObject(1, LocalTime.class); | ||
|
||
Assert.assertEquals( LocalTime.MIN, localTime); | ||
|
||
|
||
} | ||
} |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The assertTrue here was fine.