Fix postgres OID type decoding #495
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mp911de
pushed a commit
that referenced
this pull request
Feb 17, 2022
Co-authored-by: k.tokarev <k.tokarev@a1-systems.com> [#495]
|
Thank you for your contribution. That's merged and backported now. |
mp911de
added a commit
that referenced
this pull request
Feb 17, 2022
Fix OID decoding. [#495] Signed-off-by: Mark Paluch <mpaluch@vmware.com>
mp911de
added a commit
that referenced
this pull request
Feb 17, 2022
Fix OID decoding. [#495] Signed-off-by: Mark Paluch <mpaluch@vmware.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue description
If returned OID is big enough (2314556683 for example) codec throws NumberFormatException.
New Public APIs
No new public APIs added
Additional context
According to documentation (https://www.postgresql.org/docs/12/datatype-oid.html) OID type is "an unsigned four-byte integer", so it is incorrect to decode it as java Integer (which is signed an so has lower max value).
This pull request decodes OIDs as Long to fix the problem