Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support to parse timestamps with +hh:mm:ss offset #510

Closed
wants to merge 1 commit into from
Closed

Add support to parse timestamps with +hh:mm:ss offset #510

wants to merge 1 commit into from

Conversation

khlopkov
Copy link

@khlopkov khlopkov commented May 5, 2022 •
edited

Make sure that:

  • You have read the contribution guidelines.
  • You have created a feature request first to discuss your contribution intent. Please reference the feature request ticket number in the pull request.
  • You use the code formatters provided here and have them applied to your changes. Don't submit any formatting related changes.
  • You submit test cases (unit or integration tests) that back your changes.

Issue description

Previously parsing timestamp with timezone failed if offset had format +hh:mm:ss. This PR fixes it
Fixes #509

New Public APIs

There are no new APIs.

Additional context

Issue was encountered on postgresql:10-alpine docker image

@mp911de
Copy link
Collaborator

mp911de commented May 17, 2022

The changes above break the build because +HH:mm:ss is not a supported pattern. +HH:MM:ss (uppercase M) works but that breaks other test. The contribution needs a bit more work, currently looking into it.

@mp911de mp911de changed the title Fix: parse timestamps with +hh:mm:ss offset Add support to parse timestamps with +hh:mm:ss offset May 17, 2022
@mp911de mp911de added the type: enhancement A general enhancement label May 17, 2022
@mp911de mp911de added this to the 0.8.13.RELEASE milestone May 17, 2022
mp911de pushed a commit that referenced this pull request May 17, 2022
@mp911de
Add support to parse timestamps with +hh:mm:ss offset.
d748e92 
[resolves #509][#510]
@mp911de mp911de closed this in ff21b5a May 17, 2022
mp911de pushed a commit that referenced this pull request May 17, 2022
@mp911de
Add support to parse timestamps with +hh:mm:ss offset.
c8dfac2 
[resolves #509][#510]
mp911de added a commit that referenced this pull request May 17, 2022
@mp911de
Polishing.
95d9eee 
Add support for offset representation variants (short and full).

[#509][resolves #510]

Signed-off-by: Mark Paluch <mpaluch@vmware.com>
mp911de pushed a commit that referenced this pull request May 17, 2022
@mp911de
Add support to parse timestamps with +hh:mm:ss offset.
4a3b384 
[resolves #509][#510]
mp911de added a commit that referenced this pull request May 17, 2022
@mp911de
Polishing.
7bae0e3 
Add support for offset representation variants (short and full).

[#509][resolves #510]

Signed-off-by: Mark Paluch <mpaluch@vmware.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
type: enhancement A general enhancement
Projects
None yet
Milestone
0.8.13.RELEASE
Development

Successfully merging this pull request may close these issues.

Issue parsing timestamp with timezone having offset of format +hh:mm:ss
2 participants
@khlopkov @mp911de