Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Accept Long in CommandComplete #598

Closed
wants to merge 1 commit into from
Closed

Accept Long in CommandComplete #598

wants to merge 1 commit into from

Conversation

chrischall
Copy link

Make sure that:

  • You have read the contribution guidelines.
  • You have created a feature request first to discuss your contribution intent. Please reference the feature request ticket number in the pull request.
  • You use the code formatters provided here and have them applied to your changes. Don't submit any formatting related changes.
  • You submit test cases (unit or integration tests) that back your changes.

Issue description

gh-597 - Driver reports I/O error when rowsUpdated is greater than Integer.MAX_VALUE

Changes i.r.p.m.b.CommandComplete.rows from Integer to Long

New Public APIs

None.

Additional context

None.

@mp911de mp911de changed the title gh-597 - changing i.r.p.m.b.CommandComplete.rows from Integer to Long Accept Long in CommandComplete Jun 16, 2023
@mp911de mp911de added the type: bug A general bug label Jun 16, 2023
@mp911de mp911de added this to the 1.0.2.RELEASE milestone Jun 16, 2023
@mp911de mp911de linked an issue Jun 16, 2023 that may be closed by this pull request
Driver reports I/O error when rowsUpdated is greater than Integer.MAX_VALUE #597
Closed
mp911de pushed a commit that referenced this pull request Jun 16, 2023
@mp911de
Accept Long in CommandComplete.
808589d 
[resolves #597][#598]
mp911de added a commit that referenced this pull request Jun 16, 2023
@mp911de
Polishing.
a51504e 
Guard long adding against overflows.

[#597][#598]

Signed-off-by: Mark Paluch <mpaluch@vmware.com>
mp911de pushed a commit that referenced this pull request Jun 16, 2023
@mp911de
Accept Long in CommandComplete.
cb8b5ec 
[resolves #597][#598]
mp911de added a commit that referenced this pull request Jun 16, 2023
@mp911de
Polishing.
9b656c9 
Guard long adding against overflows.

[#597][#598]

Signed-off-by: Mark Paluch <mpaluch@vmware.com>
@mp911de
Copy link
Collaborator

mp911de commented Jun 16, 2023

Thank you for your contribution. That's merged, polished, and backported now.

@mp911de mp911de closed this Jun 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
type: bug A general bug
Projects
None yet
Milestone
1.0.2.RELEASE
Development

Successfully merging this pull request may close these issues.

Driver reports I/O error when rowsUpdated is greater than Integer.MAX_VALUE
2 participants
@chrischall @mp911de