Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hypercorn use loop kw in BaseEventLoop which is not a keyword anymore in py3.10 #42

Closed
MikHulk opened this issue Sep 26, 2021 · 2 comments
Closed

Hypercorn use loop kw in BaseEventLoop which is not a keyword anymore in py3.10 #42

MikHulk opened this issue Sep 26, 2021 · 2 comments

Comments

@MikHulk
Copy link

MikHulk commented Sep 26, 2021

Hi,

I didn't dig this. But it appears that quart is broken with 3.10: https://gitlab.com/pgjones/quart/-/issues/435

When I tried to fix the issue removing loop key word usage in BaseEventLoop.create_server after removed loop kw in quart and here the server run as expected. But I am not sure if is there any side effect to do that. If you want I can make a PR of my changes. Please let me know.
@MikHulk
Copy link
Author

MikHulk commented Sep 26, 2021 •
edited
Loading

https://docs.python.org/3.10/whatsnew/3.10.html#changes-in-the-python-api

https://bugs.python.org/issue42392

hwittenborn added a commit to hwittenborn/drone-global-env that referenced this issue Oct 11, 2021
@hwittenborn
Fixed issue with version of base image
42bc1dd 
Hypercorn is having issues with the latest version of Python (3.10), so 
we're moving back to 3.8 for the time being.

See pgjones/hypercorn#42 for more information.
hwittenborn added a commit to hwittenborn/drone-global-triggers that referenced this issue Oct 11, 2021
@hwittenborn
Fixed issue with version of base image
03fb54f 
Hypercorn is having issues with the latest version of Python (3.10), so 
we're moving back to 3.8 for the time being.

See pgjones/hypercorn#42 for more information.
@pgjones
Copy link
Owner

pgjones commented Nov 6, 2021

This is fixed with 8517557

@pgjones pgjones closed this as completed Nov 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@pgjones @MikHulk