Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Sign upFixed JSON bug and made a short explanation about API #3
Conversation
kaspergrubbe
added some commits
Aug 5, 2012
This comment has been minimized.
This comment has been minimized.
|
Hi Kasper - this looks great/thanks! One request though, could you remove the .rvmrc from the pull request? I think you added that by mistake. |
This comment has been minimized.
This comment has been minimized.
ghost
commented
Aug 6, 2012
|
Oh, I did a git add -A, and it also added the .rvmrc, but it is removed now :-) |
This comment has been minimized.
This comment has been minimized.
|
Awesome thanks! I'll update pwpush.com before EOD today. |
added a commit
that referenced
this pull request
Aug 6, 2012
pglombardo
merged commit c2bd7e6
into
pglombardo:master
Aug 6, 2012
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
ghost commentedAug 5, 2012
Hi!
Somebody on Reddit was talking about this project, and they wanted an API for integration with Powershell. I initially wanted to add that functionality, but I saw an API-controller that didn't do much, and saw an opportunity to use the PasswordController for it instead.
Let me know what you think.
Greetings,
Kasper.