Don't expose password to link previewers #60
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Doh thanks for letting me know. I use Slack and this doesn't happen. I'll add the meta tag and update this issue. |
|
I have this change added locally and will update pwpush.com late-night tonight or early tomorrow morning. |
|
Somehow this change got lost and never deployed. Pushing this out today. |
|
Looks great! Thanks for the suggestion.
|
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A chat client I use has link previews, and it kinda defeats the purpose of the website:
It looks for the meta tag
description, and failing to find that it toString()'s the body, resulting in what you see.Adding something like
<meta name="description" content="A password pushing website">to the html output would help mitigate this issue.