Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Tests: Set Bundle Config Option #763

Merged
merged 1 commit into from Jan 27, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
70 changes: 0 additions & 70 deletions .circleci/config.yml

This file was deleted.

1 change: 1 addition & 0 deletions .github/workflows/ruby-tests.yml
Expand Up @@ -62,6 +62,7 @@ jobs:
run: |
gem install bundler
bundle config path vendor/bundle
bundle config set with 'sqlite'
bundle install --jobs 4 --retry 3
yarn install --frozen-lockfile
- name: Run tests
Expand Down
7 changes: 3 additions & 4 deletions README.md
Expand Up @@ -114,10 +114,6 @@ _There used to be a 3rd party blog post with instructions but it's been deleted.

See [issue #277](https://github.com/pglombardo/PasswordPusher/issues/277)

## On OpenShift

See our [OpenShift documentation](https://github.com/pglombardo/PasswordPusher/tree/master/containers/docker#pwpush-openshift).

## On Heroku

One click deploy to [Heroku Cloud](https://www.heroku.com) without having to set up servers.
Expand All @@ -134,6 +130,7 @@ Make sure you have git and Ruby installed and then:
git clone git@github.com:pglombardo/PasswordPusher.git
cd PasswordPusher
gem install bundler
bundle config set with 'sqlite' # Or 'postgres' or 'mysql'
bundle install --without development production test --deployment
bundle exec rake assets:precompile
RAILS_ENV=private ./bin/rake db:setup
Expand Down Expand Up @@ -239,6 +236,8 @@ Thanks to:

* [@sfarosu](https://github.com/sfarosu) for [contributing](https://github.com/pglombardo/PasswordPusher/pull/82) the Docker, Kubernetes & OpenShift container support.

* [*sirux88](https://github.com/sirux88) for cleaning up the Docker files and adding multistage builds.

## Other

Thanks to:
Expand Down
22 changes: 0 additions & 22 deletions containers/docker/README.md
Expand Up @@ -74,25 +74,3 @@ You can either configure your MySQL server to use these credentials or override
_Note: Providing a MySQL password on the command line is far less than ideal_

Available on Docker hub: [pwpush-mysql](https://hub.docker.com/repository/docker/pglombardo/pwpush-mysql)

## Other

### OpenShift

_Note: The OpenShift container hasn't been maintained. It may still work but likely has fallen behind on dependencies and updates. If you want an updated OpenShift container, please let me know by filing a Github issue stating so. Thanks!_

You can run Password Pusher in OpenShift in 2 ways:
- ephemeral (with no persistent storage): `oc new-app docker.io/pglombardo/pwpush-ephemeral:latest`
- from an OpenShift template/buildconfig/deploymentconfig and PostgreSQL persistent from the official OpenShift template:
```
oc login https://your_openshift_url
oc new-project passwordpusher
cd ~ && git clone https://github.com/pglombardo/PasswordPusher.git && cd ~/PasswordPusher/docker/passwordpusher-openshift
oc create -f template-with-buildconfig.yaml
oc new-app postgresql-persistent -p MEMORY_LIMIT=512Mi -p NAMESPACE=openshift -p DATABASE_SERVICE_NAME=postgresql -p POSTGRESQL_USER=passwordpusher_user -p POSTGRESQL_PASSWORD=passwordpusher_passwd -p POSTGRESQL_DATABASE=passwordpusher_db -p VOLUME_CAPACITY=1Gi -p POSTGRESQL_VERSION=9.5
oc new-app --template=passwordpusher
```
OpenShift observations:
- your cluster needs persistent storage for PostgreSQL to save the data
- if you want the Password Pusher template to be available to ALL the projects (Other category in the catalog) in the cluster you need to create the template in the OpenShift namespace: `oc create -f template-with-buildconfig.yaml -n openshift`
- if you want to change the PostgreSQL credentials, modify the `DATABASE_URL` environment variable in the `docker/passwordpusher-openshift/Dockerfile` and also update the credentials when you launch the PostgreSQL installation a few lines above
38 changes: 0 additions & 38 deletions containers/docker/pwpush-openshift/Dockerfile

This file was deleted.

120 changes: 0 additions & 120 deletions containers/docker/pwpush-openshift/template-with-buildconfig.yaml

This file was deleted.