Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Verify replication slots upon startup #157

Closed
jesperpedersen opened this issue Dec 5, 2023 · 5 comments
Closed

Verify replication slots upon startup #157

jesperpedersen opened this issue Dec 5, 2023 · 5 comments
Assignees
Labels
enhancement Improvement to an existing feature

Comments

@jesperpedersen
Copy link
Member

We should verify that backup_slot and wal_slot are valid on the server in question.

If not, then it is a FATAL and pgmoneta should be stopped.

@jesperpedersen jesperpedersen added the enhancement Improvement to an existing feature label Dec 5, 2023
@jesperpedersen
Copy link
Member Author

F.ex.

postgres=# SELECT slot_name, slot_type FROM pg_replication_slots;
 slot_name | slot_type 
-----------+-----------
 repl      | physical
(1 row)

@Jubilee101
Copy link
Collaborator

Got it! I'll work on this. One problem we found constantly is missing WAL segments when there's no replication slot configured. Currently we do nothing when there is no replication slot configured. Should we make wal_slot a required configuration? Or can we create a replication slot automatically for user if there's none?

@Jubilee101 Jubilee101 self-assigned this Dec 6, 2023
@jesperpedersen
Copy link
Member Author

I added #160 for the first part, and #161 for the latter

@jesperpedersen
Copy link
Member Author

@Jubilee101
Copy link
Collaborator

Got it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Improvement to an existing feature
Projects
None yet
Development

No branches or pull requests

2 participants