Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Password Generation Function Generates Strings Containing Configuration File Comment Characters #262

Closed
joanjeremiah opened this issue Apr 12, 2024 · 1 comment
Closed

Password Generation Function Generates Strings Containing Configuration File Comment Characters #262

joanjeremiah opened this issue Apr 12, 2024 · 1 comment
Assignees
@joanjeremiah
Labels
bug Something isn't working

Comments

@joanjeremiah
Copy link
Contributor

I noticed the generate_password function in the admin.c file is currently generating passwords that may contain characters '#' and ';'. These characters pose a problem when used in passwords intended for configuration files, as they could inadvertently trigger comment recognition ( as an inline comment ) within the configuration syntax.

Possible solutions include excluding '#' and ';' characters from the list of characters used in password generation. @jesperpedersen Can I implement this solution?
@joanjeremiah joanjeremiah added the bug Something isn't working label Apr 12, 2024
@jesperpedersen
Copy link
Member

Yes

joanjeremiah added a commit to joanjeremiah/pgmoneta that referenced this issue Apr 12, 2024
@joanjeremiah
[pgmoneta#262] Fix password generation issue
403124f
joanjeremiah added a commit to joanjeremiah/pgmoneta that referenced this issue Apr 12, 2024
@joanjeremiah
[pgmoneta#262] pgmoneta#262
46f5bd0
jesperpedersen pushed a commit that referenced this issue Apr 12, 2024
@joanjeremiah @jesperpedersen
[#262] Password Generation Function Generates Strings Containing Conf…
7e9af52 
…iguration File Comment Characters
jesperpedersen pushed a commit that referenced this issue Apr 12, 2024
@joanjeremiah @jesperpedersen
[#262] Password Generation Function Generates Strings Containing Conf…
9afde8e 
…iguration File Comment Characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@joanjeremiah joanjeremiah

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jesperpedersen @joanjeremiah