Skip to content

Commit

Permalink
Fix LinearGaussianCPD member variables [fixes #961]
Browse files Browse the repository at this point in the history
This was causing a compilation error when declaring LinearGaussianCPDs and adding it to a LinearGaussianBayesianNetwork model
  • Loading branch information
theUltraMarine19 committed Sep 30, 2020
1 parent 1499f2c commit ae2d2a4
Show file tree
Hide file tree
Showing 2 changed files with 13 additions and 4 deletions.
4 changes: 2 additions & 2 deletions pgmpy/factors/continuous/LinearGaussianCPD.py
Original file line number Diff line number Diff line change
Expand Up @@ -79,9 +79,9 @@ def __init__(
self.evidence = evidence
self.sigma_yx = None

variables = [variable] + evidence
self.variables = [variable] + evidence
super(LinearGaussianCPD, self).__init__(
variables, pdf="gaussian", mean=self.mean, covariance=self.variance
self.variables, pdf="gaussian", mean=self.mean, covariance=self.variance
)

def sum_of_product(self, xi, xj):
Expand Down
13 changes: 11 additions & 2 deletions pgmpy/tests/test_models/test_LinearGaussianBayesianNetwork.py
Original file line number Diff line number Diff line change
Expand Up @@ -7,15 +7,24 @@
from pgmpy.factors.discrete import TabularCPD
from pgmpy.models import LinearGaussianBayesianNetwork


class TestLGBNMethods(unittest.TestCase):
@unittest.skip("TODO")
def setUp(self):
self.model = LinearGaussianBayesianNetwork([("x1", "x2"), ("x2", "x3")])
self.cpd1 = LinearGaussianCPD("x1", [1], 4)
self.cpd2 = LinearGaussianCPD("x2", [-5, 0.5], 4, ["x1"])
self.cpd3 = LinearGaussianCPD("x3", [4, -1], 3, ["x2"])

def test_cpds_simple(self):
self.assertEqual("x1", self.cpd1.variable)
self.assertEqual(4, self.cpd1.variance)
self.assertEqual([1], self.cpd1.mean)

self.model.add_cpds(self.cpd1)
cpd = self.model.get_cpds("x1")
self.assertEqual(cpd.variable, self.cpd1.variable)
self.assertEqual(cpd.variance, self.cpd1.variance)
self.assertEqual(cpd.mean, self.cpd1.mean)

@unittest.skip("TODO")
def test_add_cpds(self):
self.model.add_cpds(self.cpd1)
Expand Down

0 comments on commit ae2d2a4

Please sign in to comment.