handle string nan results in pool_health_check_stats #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If a node is defined but in status=unused, the `average_retry_count` and `average_duration` columns appear to return a literal string result of `-nan`. The result parsing switch correctly returns `math.NaN()` in this case, but will return `false` as the second return value, leading to errors being logged: ``` ts=2022-01-24T15:09:10.003Z caller=log.go:168 level=info msg="error parsing" err="Unexpected error parsing column: pool_health_check_stats average_retry_count [45 110 97 110]\n" ts=2022-01-24T15:09:10.003Z caller=log.go:168 level=info msg="error parsing" err="Unexpected error parsing column: pool_health_check_stats average_duration [45 110 97 110]\n" ``` (45, 110, 97, 110 are the sequential ordinal values for `-nan`) Check for a literal value of `-nan` in the string/byte parsing portion of `dbToFloat64()` and return `math.NaN(), true`, since in this case we are correctly forwarding a NaN value.
|
screenshot of the problematic data:
|
|
(I poked around in the actual pgpool code and could not immediately suss out why string |
n-oden
added a commit
to odenio/pgpool-cloudsql
that referenced
this pull request
Jan 24, 2022
- Cherry-pick pgpool/pgpool2_exporter#14 into our build of pgpool_exporter - Build telegraf from source; circle-ci is now 404ing the artifact link from influxdata/telegraf#10097 :( - Bump version to 1.0.5
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a node is defined but in status=unused, the
average_retry_countand
average_durationcolumns appear to return a literal stringresult of
-nan. The result parsing switch correctly returnsmath.NaN()in this case, but will returnfalseas the second returnvalue, leading to errors being logged:
(45, 110, 97, 110 are the sequential ordinal values for
-nan)Check for a literal value of
-nanin the string/byte parsing portionof
dbToFloat64()and returnmath.NaN(), true, since in this casewe are correctly forwarding a NaN value.