assert number equality within delta #93

pgrange · 2023-01-02T11:42:02Z

assert_within_delta <expected num> <actual num> <max delta>

Given an expectation of 5 and a delta of 2 this would match 3, 4, 5, 6, and 7

masukomi

overall 👍
but IF the intent was to not support decimal numbers that should be explicit in the docs, and if that wasn't the intent, then there's a bug. ;)

README.adoc

``` assert_within_delta <expected num> <actual num> <max delta> ``` Given an expectation of 5 and a delta of 2 this would match 3, 4, 5, 6, and 7

pgrange changed the title ~~Fixes #92~~ assert number equality within delta Jan 2, 2023

pgrange mentioned this pull request Jan 2, 2023

[feature] an assertion that compares numbers within a delta #92

Closed

masukomi reviewed Jan 2, 2023

View reviewed changes

README.adoc Show resolved Hide resolved

README.adoc Show resolved Hide resolved

Fixes #92

4411bc6

``` assert_within_delta <expected num> <actual num> <max delta> ``` Given an expectation of 5 and a delta of 2 this would match 3, 4, 5, 6, and 7

pgrange force-pushed the time_delta branch from 7d36dea to 4411bc6 Compare March 3, 2023 09:35

pgrange marked this pull request as ready for review March 3, 2023 09:36

pgrange merged commit 0f97767 into master Mar 3, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

assert number equality within delta #93

assert number equality within delta #93

pgrange commented Jan 2, 2023

masukomi left a comment

assert number equality within delta #93

assert number equality within delta #93

Conversation

pgrange commented Jan 2, 2023

masukomi left a comment

Choose a reason for hiding this comment