Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Call manually pageviewToGA() #9

Merged
merged 2 commits into from
Jun 19, 2015
Merged

Conversation

givanse
Copy link
Contributor

@givanse givanse commented May 27, 2015

This change allows you to send a page view with a custom url and title.

Currently I'm using it with hash fragments only, but probably its useful if you want to track query parameters too.

Usage example in a view:

import googlePageview from '../mixins/google-pageview';                          
var ga = Ember.Object.extend(googlePageview).create();

click: function() {
  // some logic
  ga.pageviewToGA(page_with_hash, updated_title);
}

@mike-north
Copy link
Collaborator

@pgrippi are you still maintaining this?

@pgrippi
Copy link
Owner

pgrippi commented Jun 19, 2015

👍

@truenorth yes I am, but I am currently moving across the country (MA to OR). I am open to giving people collaborator access to help if you'd like :)

pgrippi pushed a commit that referenced this pull request Jun 19, 2015
Call manually pageviewToGA()
@pgrippi pgrippi merged commit 05e434c into pgrippi:master Jun 19, 2015
@pgrippi
Copy link
Owner

pgrippi commented Jun 19, 2015

Version 1.4.0 published on github and npm with these changes

@mike-north
Copy link
Collaborator

@pgrippi

I am open to giving people collaborator access to help if you'd like :)

I'd be glad to help out

@givanse givanse deleted the fragment-id branch June 19, 2015 18:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants