Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add tcp host and port range configuration #114

Merged
merged 9 commits into from
Nov 20, 2023

Conversation

michalg91
Copy link
Contributor

Describe the pull request

This PR adds posibility to configure port range on tcp port forwarding also has ability to set different hostname for tcp service (eg. for usage with kubernetes loadbalancer service)

Link to the issue: n/a

Consent

  • I agree to follow the Code of Conduct by submitting this pull request.
  • I have read and acknowledged the Contributing guide.
  • I have added test cases to cover the new code or have provided the test plan.

Test plan

Copy link
Member

@unknwon unknwon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!

In addition to the code change, we also need to update example YAML config https://github.com/pgrok/pgrok/blob/main/pgrokd.exmaple.yml

internal/conf/conf.go Outdated Show resolved Hide resolved
internal/conf/conf.go Outdated Show resolved Hide resolved
Copy link

codecov bot commented Nov 17, 2023

Codecov Report

Merging #114 (26942dc) into main (747bcc7) will increase coverage by 0.18%.
Report is 1 commits behind head on main.
The diff coverage is n/a.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #114      +/-   ##
==========================================
+ Coverage   15.91%   16.10%   +0.18%     
==========================================
  Files          13       13              
  Lines         446      447       +1     
==========================================
+ Hits           71       72       +1     
  Misses        370      370              
  Partials        5        5              

Copy link
Member

@unknwon unknwon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the follow-up! Few last minor issues.

internal/conf/conf.go Outdated Show resolved Hide resolved
internal/conf/conf.go Outdated Show resolved Hide resolved
internal/sshd/client.go Outdated Show resolved Hide resolved
internal/sshd/client.go Outdated Show resolved Hide resolved
pgrokd.exmaple.yml Outdated Show resolved Hide resolved
pgrokd.exmaple.yml Outdated Show resolved Hide resolved
pgrokd.exmaple.yml Outdated Show resolved Hide resolved
Copy link
Member

@unknwon unknwon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@unknwon unknwon merged commit 425ac7c into pgrok:main Nov 20, 2023
9 checks passed
@unknwon
Copy link
Member

unknwon commented Nov 20, 2023

This change is included in https://github.com/pgrok/pgrok/releases/tag/v1.4.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants