-
Notifications
You must be signed in to change notification settings - Fork 93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add tcp host and port range configuration #114
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR!
In addition to the code change, we also need to update example YAML config https://github.com/pgrok/pgrok/blob/main/pgrokd.exmaple.yml
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #114 +/- ##
==========================================
+ Coverage 15.91% 16.10% +0.18%
==========================================
Files 13 13
Lines 446 447 +1
==========================================
+ Hits 71 72 +1
Misses 370 370
Partials 5 5 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the follow-up! Few last minor issues.
Co-authored-by: Joe Chen <jc@unknwon.io>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀
This change is included in https://github.com/pgrok/pgrok/releases/tag/v1.4.1 |
Describe the pull request
This PR adds posibility to configure port range on tcp port forwarding also has ability to set different hostname for tcp service (eg. for usage with kubernetes loadbalancer service)
Link to the issue: n/a
Consent
Test plan