Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support "server-info" OOB request #34

Merged
merged 1 commit into from
Mar 25, 2023
Merged

feat: support "server-info" OOB request #34

merged 1 commit into from
Mar 25, 2023

Conversation

unknwon
Copy link
Member

@unknwon unknwon commented Mar 25, 2023

Describe the pull request

Support "server-info" OOB request, currently only contains the host URL which could be printed to the client console.

Consent

  • I agree to follow the Code of Conduct by submitting this pull request.
  • I have read and acknowledged the Contributing guide.
  • I have added test cases to cover the new code or have provided the test plan.

Test plan

CleanShot 2023-03-25 at 22 18 54@2x

@codecov
Copy link

codecov bot commented Mar 25, 2023

Codecov Report

Merging #34 (e2297cc) into main (e668de1) will increase coverage by 4.29%.
The diff coverage is 33.92%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #34      +/-   ##
==========================================
+ Coverage   12.46%   16.75%   +4.29%     
==========================================
  Files          11       12       +1     
  Lines         345      370      +25     
==========================================
+ Hits           43       62      +19     
- Misses        299      303       +4     
- Partials        3        5       +2     

@unknwon unknwon merged commit 42a0d86 into main Mar 25, 2023
@unknwon unknwon deleted the jc/server-info branch March 25, 2023 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant