Skip to content

Commit

Permalink
test for request end
Browse files Browse the repository at this point in the history
  • Loading branch information
pgte committed Mar 21, 2013
1 parent d949717 commit 83a9be2
Show file tree
Hide file tree
Showing 3 changed files with 49 additions and 7 deletions.
12 changes: 6 additions & 6 deletions listeners/http-server-request-end.js
@@ -1,15 +1,15 @@
/// http-server-request-end

module.exports =
function listener(res, time, timeDiff) {
function listener(req, time, timeDiff) {
return {
event: 'http-server-request-end',
time: time,
timeDiff: timeDiff,
method: res.method,
path: res.url,
headers: res.headers,
host: res.headers.host,
bytesRead: res.client.bytesRead
method: req.method,
path: req.url,
headers: req.headers,
host: req.headers.host,
bytesRead: req.client.bytesRead
};
};
1 change: 0 additions & 1 deletion listeners/http-server-response-end.js
Expand Up @@ -2,7 +2,6 @@

module.exports =
function listener(res, time, timeDiff) {
console.log('res.statusCode:', res.statusCode);
var req = res.__req;
return {
event: 'http-server-response-end',
Expand Down
43 changes: 43 additions & 0 deletions tests/http_server.js
Expand Up @@ -48,6 +48,49 @@ test('emits http-server-request-begin', function(t) {
});
});

test('emits http-server-request-end', function(t) {
t.plan(8);

var server = http.createServer();
server.on('request', function(req, res) {
var d = domain.create();

d.add(req);
d.add(res);

req.resume();
res.end('Hey');
});
var port = randomPort();
server.listen(port);

var s = S();

s.on('readable', function() {
var event = s.read();
if (event && event.event == 'http-server-request-end') {
t.type(event.time, 'number');
t.ok(event.timeDiff >= 0);
t.equal(event.method, 'GET');
t.equal(event.path, '/abcdef?abc=def');
t.equal(event.host, 'localhost:' + port);
t.type(event.headers, 'object');
t.type(event.bytesRead, 'number');
t.ok(event.bytesRead > 0);
}
});

server.once('listening', function(err) {
if (err) throw err;
http.get('http://localhost:' + port + '/abcdef?abc=def', function(res) {
res.resume();
res.once('end', function() {
server.close();
});
});
});
});

test('emits http-server-response-end', function(t) {
t.plan(7);

Expand Down

0 comments on commit 83a9be2

Please sign in to comment.