Skip to content
This repository has been archived by the owner on May 16, 2019. It is now read-only.

Support object literal arguments #13

Open
malteseduck opened this issue Feb 28, 2018 · 3 comments
Open

Support object literal arguments #13

malteseduck opened this issue Feb 28, 2018 · 3 comments

Comments

@malteseduck
Copy link

Are there plans to support these? Your library is my favorite GraphQL library for Java/Kotlin, but not being able to send objects to my mutations makes it a deal-breaker for many of my projects.

@prestongarno
Copy link

prestongarno commented Mar 13, 2018

I was curious as well, and it might be because of the rules for input objects listed in the spec?

http://facebook.github.io/graphql/October2016/#sec-Input-Objects

Moshi Json custom type adapters do this pretty cleanly and something similar might work here, though. Explicitly declaring schema types is already required in kgraphql, why not add a input object declaration DSL in the same place? @pgutkowski thoughts?

@pgutkowski
Copy link
Owner

Hi @malteseduck, thank you for your report.

I'd love to introduce support for object literals, but unfortunately lately I don't have much time due to my career and personal responsibilities. Additionally, responding to @prestongarno question, this feature is not there mainly because request parsing module is not designed well and it should be refactored before adding features.

I hope you know that you still can pass objects as arguments in variables, like in this test case

Anyway, with subscriptions and pagination it will be my main concern for future development.

@jeggy
Copy link
Contributor

jeggy commented Nov 22, 2018

What's needed to implement this?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants