This repository has been archived by the owner on May 16, 2019. It is now read-only.
Kotlin 1.3 release fixes #33
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Fixed imports - coroutineDispatcher now using the default dispatcher - Made ParallelRequestExecutor a CoroutineScope - Pulled up Jackson version
|
Thank you @vemilyus! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Kotlin 1.3 and Coroutines 1.0 have changed their semantics a tiny little bit, now the coroutine builders require a coroutine scope, which can be either implemented using the interface or using
GlobalScope.Also
CommonPooldoesn't exist anymore, now you have to use one of the dispatchers provided byDispatchersor create your own.