Aggregate using in+out bytes for bidirectional flows #28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some sources of data, e.g. ASA NSEL, record a bidirectional flow record with separate counters for in/out bytes and in/out packets. This patch makes aggregation over "packets", "bytes", "bps" etc look at the *sum* of the input and output counters. Previously they would use only the input counters. Query types which explicitly look at one direction, like "ibyte" and "obyte", are unchanged. Processing of unidirectional flows is not affected, because these store values in the "in" counters only - the "out" counters are zero, so using the sum of in+out is the same. The resulting code is simpler: it doesn't have to calculate both in/out values everywhere. It also uses accessor functions for all values, which means no special cases for r->counter[cindex].
|
Thx. Makes sense to include bidirectional flow record aggregation. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some sources of data, e.g. ASA NSEL, record a bidirectional flow record
with separate counters for in/out bytes and in/out packets. This patch
makes aggregation over "packets", "bytes", "bps" etc look at the sum of
the input and output counters. Previously they would use only the input
counters.
Query types which explicitly look at one direction, like "ibyte" and
"obyte", are unchanged.
Processing of unidirectional flows is not affected, because these store
values in the "in" counters only - the "out" counters are zero, so using the
sum of in+out is the same.
The resulting code is simpler: it doesn't have to calculate both in/out
values everywhere. It also uses accessor functions for all values, which
means no special cases for
r->counter[cindex].