Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unconfident QC Check not behaving as expected #27

Closed
mgopez opened this issue Jan 19, 2018 · 1 comment
Closed

Unconfident QC Check not behaving as expected #27

mgopez opened this issue Jan 19, 2018 · 1 comment
Labels

Comments

@mgopez
Copy link
Member

mgopez commented Jan 19, 2018

For QC Check 4 (Unconfident Results) bio_hansel is reporting that the downstream subtypes do not exist within the DataFrame. After manually looking at the detailed hansel results, I confirmed that the downstream subtypes' tiles exist within the result.

Within subtyper.py
Lines with:

st.non_present_subtypes = [x for x in possible_downstream_subtypes if x not in df['subtype']]

should be replaced with something like:

st.non_present_subtypes = [x for x in possible_downstream_subtypes if not df['subtype'].str.contains(x).any()]

to properly check the DataFrame for the possible downstream subtypes.

@peterk87
Copy link
Contributor

Resolved with PR #28

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants