Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Command-line arg variable name and SubtypingParams instance variable name synchronization #63

Open
peterk87 opened this issue Jan 23, 2019 · 1 comment

Comments

@peterk87
Copy link
Contributor

Command-line arg variable names should be synchronized with the SubtypingParams so that they can be all checked for and assigned with a couple lines of code, e.g.:

for param_key in subtyping_params.__dict__.keys():
    if param_key in args.__dict__:
        subtyping_params.__dict__[param_key] = args.__dict__[param_key]

This would allow new user-adjustable params to be added with less boilerplate to ensure they are set appropriate and to easily reference where a particular command-line parameter is used.

Related to #61

@glabbe
Copy link
Collaborator

glabbe commented Jan 23, 2019

Sounds good, thanks for the suggestion Peter!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants