Open software engineering platform and fun adventure game
PHP JavaScript CSS C Groff Shell Other
Latest commit c55de86 Aug 27, 2016 @epriestley epriestley Return Diffusion diffs through Files, not directly over Conduit
Fixes T10423. Ref T11524. This changes `diffusion.rawdiffquery` to return a file PHID instead of a blob of data.

This is better in general, but particularly better for huge diffs (as in T10423) and diffs with non-utf8 data (as in T10423).

Test Plan:
  - Used `bin/differential extract` to extract a latin1 diff, got a clean diff.
  - Used `bin/repository reparse --herald` to rerun herald on a latin1 diff, got a clean result.
  - Pushed latin1 diffs to test commit hooks.
  - Triggered the the too large / too slow logic.
  - Viewed latin1 diffs in Diffusion.
  - Used "blame past this change" in Diffusion to hit the `before` logic.

Reviewers: chad

Reviewed By: chad

Subscribers: eadler

Maniphest Tasks: T10423, T11524

Differential Revision:

Phabricator is a collection of web applications which help software companies build better software.

Phabricator includes applications for:

  • reviewing and auditing source code;
  • hosting and browsing repositories;
  • tracking bugs;
  • managing projects;
  • conversing with team members;
  • assembling a party to venture forth;
  • writing stuff down and reading it later;
  • hiding stuff from coworkers; and
  • also some other things.

You can learn more about the project (and find links to documentation and resources) at

Phabricator is developed and maintained by Phacility.


For resources on filing bugs, requesting features, reporting security issues, and getting other kinds of support, see Support Resources.


We do not accept pull requests through GitHub. If you would like to contribute code, please read our Contributor's Guide.


Phabricator is released under the Apache 2.0 license except as otherwise noted.