Skip to content


Subversion checkout URL

You can clone with
Download ZIP
Open software engineering platform and fun adventure game
PHP JavaScript CSS C Groff Shell Other
Branch: master

Make Diffusion "Last Modified" rendering less fragile

Ref T9524. Because fetching the last time files were modified in Diffusion can be slow, we bring it in over Ajax.

The logic to fetch and paint the table is kind of fragile because there are two different definitions of the columns right now and we break in a bad way if they differ.

In particular, calling `diffusion.updatecoverage` can populate a "lint commit" for a repository, which tries to generate lint information in one of the views (but not the other one).

In the longer run I think we're removing some of the concepts here and this rendering should be rebuilt to not have two separate column definitions, but just make it degrade gracefully for now since those are larger changes.

Test Plan:
Reproduced the issue in T9524 by calling `diffusion.updatecoverage` on a repostiory. Specifically, this has a side effect of creating a "lint commit" which triggers a "lint" column in this table, sort of.

Applied this patch, got a clean render.

Reviewers: chad

Reviewed By: chad

Maniphest Tasks: T9524

Differential Revision:
latest commit 2a355d8548
@epriestley epriestley authored

Phabricator is an open source collection of web applications which help software companies build better software.

Phabricator includes applications for:

  • reviewing and auditing source code;
  • hosting and browsing repositories;
  • tracking bugs;
  • managing projects;
  • conversing with team members;
  • assembling a party to venture forth;
  • writing stuff down and reading it later;
  • hiding stuff from coworkers; and
  • also some other things.

You can learn more about the project (and find links to documentation and resources) at

Phabricator is developed and maintained by Phacility.


Please update your install to HEAD before filing bug reports. Follow our bug reporting guide for complete instructions.


We're big fans of feature requests that state core problems, not just 'add this'. We've compiled a short guide to effective upstream requests here.


Please visit our IRC Channel (#phabricator on FreeNode) to talk with other members of the Phabricator community. There might be someone there who can help you with setup issues or what image to choose for a macro.


Phabricator participates in HackerOne and may pay out for various issues reported there. You can find out more information on our HackerOne page.


We do not accept pull requests through GitHub. If you would like to contribute code, please read our Contributor's Guide for more information.


Phabricator is released under the Apache 2.0 license except as otherwise noted.

Something went wrong with that request. Please try again.