Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix segfault with php 5.5 & auto_prepend_file #48

Closed
wants to merge 1 commit into from

Conversation

jocel1
Copy link

@jocel1 jocel1 commented Sep 25, 2014

Fix a crash when xhprof_enable() is used in an auto_prepend_file

@epriestley
Copy link
Member

Can you please sign the CLA?

https://secure.phabricator.com/L28

@jocel1
Copy link
Author

jocel1 commented Sep 25, 2014

done :)

@Xon Xon mentioned this pull request Jan 4, 2015
@arkonan
Copy link

arkonan commented Jan 14, 2015

Was seeing this segfault with php 5.5.18. Can confirm that this PR fixes the crash.

@guilhermeblanco
Copy link

@epriestley care to review and merge?

@voukka
Copy link

voukka commented Feb 18, 2015

I confirm that the PR fixes the crash in my environment. @epriestley please review and merge

PHP 5.5.9-1ubuntu4.6 (cli) (built: Feb 13 2015 19:17:11)
Copyright (c) 1997-2014 The PHP Group
Zend Engine v2.5.0, Copyright (c) 1998-2014 Zend Technologies
with Zend OPcache v7.0.3, Copyright (c) 1999-2014, by Zend Technologies

epriestley pushed a commit that referenced this pull request Feb 26, 2015
epriestley pushed a commit that referenced this pull request Feb 26, 2015
@epriestley
Copy link
Member

I added a test for this in 63169a7 and applied a smaller fix in a3bc669 (some of the changes seemed unrelated). Thanks!

@epriestley epriestley closed this Feb 26, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants