Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Union implementation #10

Closed
niteria opened this issue Nov 30, 2016 · 1 comment
Closed

Union implementation #10

niteria opened this issue Nov 30, 2016 · 1 comment

Comments

@niteria
Copy link

@niteria niteria commented Nov 30, 2016

You're probably aware of this, but just in case you weren't.

Your union implementation overflows Int for:

iterate (\a -> union a a) a

I needed to implement something like your package for GHC and that's what I ended up with:

https://phabricator.haskell.org/diffusion/GHC/browse/master/compiler/utils/UniqDFM.hs;20c06143a7bfc6548351e610350a8e1c0d8a0bb9$128-136

@phadej

This comment has been minimized.

Copy link
Owner

@phadej phadej commented Apr 5, 2017

Hmm I guess I can fix it by re-indexing after union.

phadej added a commit that referenced this issue Apr 5, 2017
@phadej phadej closed this in 0fa521e Apr 15, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.