Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should PartialOrd be a superclass of joins and meets? #54

Open
ocharles opened this issue Sep 23, 2017 · 2 comments
Open

Should PartialOrd be a superclass of joins and meets? #54

ocharles opened this issue Sep 23, 2017 · 2 comments

Comments

@ocharles
Copy link
Contributor

If "n mathematics, a join-semilattice (or upper semilattice) is a partially ordered set that has a join (a least upper bound)", shouldn't we have

class PartialOrd a => JoinSemiLattice a where
class PartialOrd a => MeetSemiLattice a where

?

This would have pre-empted the problems reported in #53 and #52.

@phadej
Copy link
Collaborator

phadej commented Sep 26, 2017

That will make life hard for types without decidable equality, like JoinSemiLattice v => JoinSemiLattice (k -> v)

@ocharles
Copy link
Contributor Author

Ah, that is problematic.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants