Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove hardcoded inputs and outputs in collect_accessions.py #244

Closed
2 tasks
mbonsma opened this issue Sep 20, 2017 · 5 comments
Closed
2 tasks

Remove hardcoded inputs and outputs in collect_accessions.py #244

mbonsma opened this issue Sep 20, 2017 · 5 comments

Comments

@mbonsma
Copy link
Member

mbonsma commented Sep 20, 2017

collect_accessions.py (PR #243) has file names hardcoded in the input and output. It should be modified to:

  • accept the input and output filenames as command line arguments, and
  • have a docstring that explains what the arguments are and what the script does.

See crispr_finder.py for an example of a docstring (top rows in triple quotes) and accepting arguments.

@ghost
Copy link

ghost commented Oct 3, 2017

Hi - can I work on this bug as part of Hacktoberfest?!

@mbonsma
Copy link
Member Author

mbonsma commented Oct 4, 2017

@thegreyelephant sure, please do!

@thisisjaid
Copy link
Contributor

Sorry I had kind of already addressed this as part of the Pandas rewrite PR :/

@ghost
Copy link

ghost commented Oct 5, 2017

@thisisjaid Oh - OK. No worries, I'll look for another beginner bug!

@QuLogic
Copy link
Contributor

QuLogic commented Nov 3, 2017

@mbonsma So close this?

@mbonsma mbonsma closed this as completed Nov 3, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants