Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Google Sync support #29

Open
devnull69 opened this issue Apr 9, 2014 · 11 comments
Open

Google Sync support #29

devnull69 opened this issue Apr 9, 2014 · 11 comments

Comments

@devnull69
Copy link

Hi there

is it planned to change the extension to store the options and extension information (and everything else currently located in localStorage) in Google Sync? If not, I could implement it in my fork and send a pull request afterwards ...

Regards
Thomas

@phaistonian
Copy link
Owner

Hey Thomas.

I was planning to implement some sort of syncing using BSync (used in Chrome Notepad extension), but unfortunately spare time is not something easy to find any more.

That said, It'd be great if you could provide Google Sync functionality and I will be more than happy to merge it.

@devnull69
Copy link
Author

Would you prefer to let the user choose between localStorage and Google sync or should Google sync be the preferred way with localStorage as a fallback?

@phaistonian
Copy link
Owner

Both will do do.

In fact, utilising both methods (transparently) would probably be the way to go.

Again, it's up to you :-)

@kzahel
Copy link

kzahel commented Sep 4, 2014

Again I lost my list of apps :-(. I might create a pull request having the extension use chrome.storage.sync instead of localStorage, which seems to get destroyed pretty frequently

@phaistonian
Copy link
Owner

@kzahel: Wow, I had no idea such an API was implemented (I haven been away from extensions for quite some time).

Yes, that 'd be ideal.

Please create this pull request, I am sure more people will be benefited from such a change.

@kzahel
Copy link

kzahel commented Sep 4, 2014

kzahel@f687e00
I tried real quick to see if doing the braindead thing would work, but it's not working very well because of what appears to be race conditions when saving to the "data" key asynchronously. So it's going to take a little refactoring ... :-(

@kzahel
Copy link

kzahel commented Sep 11, 2014

kzahel@8776300

Did a little more work, it's going to take a lot of testing before I feel it's stable at all though. I'm not sure if it's broken other things yet.

I think it would make sense to only store the list of extensions in the chrome.storage.sync and the other data (ratings, etc) in the chrome.storage.local

@phaistonian
Copy link
Owner

True, that would make perfect sense.

Thank you for your efforts.

@phaistonian
Copy link
Owner

Hey @kzahel.

Any progress with this long-standing issue?

@Aplokjoy
Copy link

Wow, I had no idea such an API was implemented (I haven been away from extensions for quite some time).

Yes, that 'd be ideal.

Please create this pull request, I am sure more people will be benefited from such a change.

@Aplokjoy
Copy link

#29

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants