Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include LICENSE , README and CHANGELOG in package.xml #64

Closed
christofdamian opened this issue May 24, 2012 · 7 comments
Closed

Include LICENSE , README and CHANGELOG in package.xml #64

christofdamian opened this issue May 24, 2012 · 7 comments

Comments

@christofdamian
Copy link

I am creating an RPM for Fedora and EPEL and this came up in the review progress:
https://bugzilla.redhat.com/show_bug.cgi?id=818318#c3:

So you can request to add CHANGELOG, LICENSE and README with role="doc" and
to add tests folder as role="test" (next step will be to add a %check in the
spec to run this test suite), as this files are already there.

I can include them manually, but it would be nicer if they would be included in the pear package.
Sometimes other packages also things like composer.json .

@mlively
Copy link
Collaborator

mlively commented May 25, 2012

I am honestly not very familiar with pear and am concerned that having the package.xml file where it is that I can't get those files included. If I move the package.xml file I am not entirely sure how to make sure I get the src files in the proper location in the pear path. I can take a closer look after the weekend.

@christofdamian
Copy link
Author

I can also have a look and send you a pull request if I manage to get it
working.
It isn't urgent anyway.

We use Phake at work by the way, so thanks for your work.

Cheers
Christof
On 25 May 2012 17:33, "Mike Lively" <
reply@reply.github.com>
wrote:

I am honestly not very familiar with pear and am concerned that having the
package.xml file where it is that I can't get those files included. If I
move the package.xml file I am not entirely sure how to make sure I get the
src files in the proper location in the pear path. I can take a closer look
after the weekend.


Reply to this email directly or view it on GitHub:
#64 (comment)

@bfeaver
Copy link
Collaborator

bfeaver commented Aug 3, 2013

See closing comment in #66.

@bfeaver bfeaver closed this as completed Aug 3, 2013
@mlively mlively reopened this Aug 6, 2013
@mlively
Copy link
Collaborator

mlively commented Aug 6, 2013

Some day I swear I'll fix this...see #66

@bfeaver
Copy link
Collaborator

bfeaver commented Aug 6, 2013

I'm removing the milestone for v2.0 then.

@christofdamian
Copy link
Author

I will check with Fedora PHP guys what the plan is for composer packages. Maybe we will end up just using the tagged releases as tar files and manually installing them in place.

@mlively
Copy link
Collaborator

mlively commented Apr 6, 2014

Removed support for pear.

@mlively mlively closed this as completed Apr 6, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants