Fix #209 - Handle static:: calls for static methods in partial mocks #305
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adoy
reviewed
Jan 23, 2022
| $mockGenerator->generate($newClassName, $mockedClassList, $this->infoRegistry); | ||
|
|
||
| $this->cachedClasses[implode('__', $mockedClassList)] = $newClassName; | ||
| if ($cache) { |
There was a problem hiding this comment.
As I understand your patch you are always regenerating a new class everytime you're using the partialMock method. This may lead to a bigger memory consumption.
Would it make sense to only cache two différent versions of the mocked class ? One for Phake::mock() and one for Phake::partialMock() ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An attempt do deal with mocking static methods in partial mocks so static:: access to the methods works.