Some small tweaks to the task processor that should make it more robust #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
debarshiray
force-pushed
the
wip/rishi/task-processor-improve-robustness
branch
from
c0f5db0
to
8455170
Compare
See commit 1de3325 for the original reason why all the queues need to be removed before dleyna_task_processor_t->on_quit_cb is run. However, if we remove them too early then there might still be tasks in flight that need to use them. https://bugzilla.redhat.com/show_bug.cgi?id=1890618 phako#2
debarshiray
force-pushed
the
wip/rishi/task-processor-improve-robustness
branch
from
8455170
to
a72188a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://bugzilla.redhat.com/show_bug.cgi?id=1890618