Skip to content
This repository has been archived by the owner on Dec 30, 2023. It is now read-only.

Typo in column define options #297

Closed
u-mulder opened this issue Jan 6, 2014 · 5 comments
Closed

Typo in column define options #297

u-mulder opened this issue Jan 6, 2014 · 5 comments

Comments

@u-mulder
Copy link

u-mulder commented Jan 6, 2014

Here http://docs.phalconphp.com/en/latest/reference/db.html#creating-tables in a table with description of options available to define a column is a little typo.
For a row with option "primary" description should be "True if the column is part of the table’s primary key" and now it's "True if the table is part of the table’s primary key".

tiraeth pushed a commit to tiraeth/phalcon-docs that referenced this issue Jan 6, 2014
@tiraeth
Copy link

tiraeth commented Jan 6, 2014

#298 - added a PR for this

ghost pushed a commit that referenced this issue Jan 6, 2014
@ghost
Copy link

ghost commented Jan 6, 2014

Corrected by @tiraeth

@ghost ghost closed this as completed Jan 6, 2014
@u-mulder
Copy link
Author

u-mulder commented Jan 6, 2014

Definitely something is wrong as the table has dissapeared.

@u-mulder
Copy link
Author

u-mulder commented Jan 6, 2014

| missed at the end of a line.

@unisys12
Copy link
Contributor

I saw this same issue on a pull request I did last night, with a different table that was missing from the docs. For some reason, I had "wordwrap" turned on in Sublime and made reading the tables uber hard. It took me until tonight, troubleshooting this issue, to figure that out. DOH! Either way, upon making the word change to the original docs (not my repo), I noticed that it added a space to the end of the sentence for some reason. Upon building, with Sphinx, it gave me a "Malformed Table" error. And yep, the table was not in the new docs. Removed the space and got everything lined back up, rebuild and wala.

As for how an extra | got in there... I cannot explain. I will of course give @tiraeth a chance to resolve though before branching and creating a pull request on it.

This issue was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants