Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG]: \Phalcon\Db\Adapter\AdapterInterface::getInternalHandler expects \PDO #15119

Closed
Jurigag opened this issue Jul 28, 2020 · 1 comment · Fixed by #15735
Closed

[BUG]: \Phalcon\Db\Adapter\AdapterInterface::getInternalHandler expects \PDO #15119

Jurigag opened this issue Jul 28, 2020 · 1 comment · Fixed by #15735
Assignees
@niden
Labels
5.0 The issues we want to solve in the 5.0 release breaks bc Functionality that breaks Backwards Compatibility bug A bug report status: medium Medium
Projects
Phalcon Roadmap

Comments

@Jurigag
Copy link
Contributor

Jurigag commented Jul 28, 2020 •
edited
Loading

Describe the bug
We have implemented custom elasticsearch adapter using AdapterInterface from phalcon, we had a return of Elastisearch client in getInternalHandler method, but since phalcon 4 return type of it is now \PDO, though whole adapter isn't really in any PDO related namespace https://github.com/phalcon/cphalcon/blob/master/phalcon/Db/Adapter/AdapterInterface.zep#L226.

To Reproduce
Implement interface and try to return something else.

Expected behavior
Allow implementing this interface without returning \PDO or implementing this method. Either move it to \Phalcon\Db\Adapter\Pdo or remove it at all.

Details

  • Phalcon version: 4.0
  • PHP Version: 7.4
  • Operating System: Ubuntu 18.04
  • Installation type: Compiling from source
  • Zephir version (if any): 0.12.19
  • Server: Nginx
  • Other related info (Database, table schema):
@Jurigag Jurigag added bug A bug report status: unverified Unverified labels Jul 28, 2020
@zsilbi zsilbi added 6.0 The issues we want to solve in the 6.0 release breaks bc Functionality that breaks Backwards Compatibility and removed status: unverified Unverified labels Sep 28, 2020
@zsilbi zsilbi added the transfer label Oct 6, 2020
@niden niden added 5.0 The issues we want to solve in the 5.0 release status: medium Medium and removed 6.0 The issues we want to solve in the 6.0 release transfer labels Oct 24, 2021
@niden niden self-assigned this Oct 24, 2021
@niden niden added this to Working on it in Phalcon Roadmap Oct 24, 2021
@niden niden mentioned this issue Oct 24, 2021
Merged
5 tasks
@niden niden linked a pull request Oct 24, 2021 that will close this issue
T15119 db getinternalhandler #15735
Merged
5 tasks
@niden
Copy link
Sponsor Member

niden commented Oct 24, 2021

Resolved in #15735

@niden niden closed this as completed Oct 24, 2021
Phalcon Roadmap automation moved this from Working on it to Implemented Oct 24, 2021
@niden niden moved this from Implemented to Released in Phalcon Roadmap Nov 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@niden niden

Labels
5.0 The issues we want to solve in the 5.0 release breaks bc Functionality that breaks Backwards Compatibility bug A bug report status: medium Medium
Projects
Phalcon v5
Archived in project
Phalcon Roadmap
  
Released
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

T15119 db getinternalhandler
3 participants
@niden @zsilbi @Jurigag