[BUG]: Loader should not load already loaded files

[michalzielanski]

I use Phalcon\Loader as the main autoloader, but some libraries (for example laminas/laminas-zendframework-bridge) register their autoloaders to load files before I can do so with $loader->loadFiles(), resulting in a "Cannot redeclare XYZ" error is raised.
Phalcon\Loader should use require_once instead of require so that the error does not appear.

cphalcon/phalcon/Loader.zep

Line 121 in 20356b6

require filePath;

cphalcon/phalcon/Loader.zep

Line 194 in 20356b6

require filePath;

cphalcon/phalcon/Loader.zep

Line 253 in 20356b6

require filePath;

cphalcon/phalcon/Loader.zep

Line 378 in 20356b6

require filePath;

To Reproduce

// file_to_load.php
<?php
function onlyTest()
{
}

// script.php
<?php
$loader = new \Phalcon\Loader();
$loader->register();

$file = __DIR__ . DIRECTORY_SEPARATOR . 'file_to_load.php';
// Simulation of loading by another autoloader.
require $file;

$loader->registerFiles([$file]);
$loader->loadFiles();

[Izopi4a]

if you change

require $file;

to

require_once $file;

i think it will be fine. Also i don't think you should be manually including files

[michalzielanski]

@Izopi4a, this is just a very simple example showing the bug. In fact, the code that registers the additional autoloader is in the composer package (laminas/laminas-zendframework-bridge required by laminas/laminas-escaper) which in turn is depending on the package I need (phpoffice/phpword:0.18.1).

Besides, you are wrong to replace require $file; with require_once $file; will not change anything, since require_once must be in Phalcon\Loader.

[Jeckerson]

Will be possible to implement since Zephir 0.14.0 stable.

[niden]

Resolved in #15698