Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG]: Rename \Phalcon\Support\Collection\Readonly for PHP 8.1 support #15767

Closed
KalleZ opened this issue Nov 6, 2021 · 1 comment · Fixed by #15768
Closed

[BUG]: Rename \Phalcon\Support\Collection\Readonly for PHP 8.1 support #15767

KalleZ opened this issue Nov 6, 2021 · 1 comment · Fixed by #15768
Assignees
@niden
Labels
5.0 The issues we want to solve in the 5.0 release bug A bug report status: medium Medium
Projects
Phalcon Roadmap

Comments

@KalleZ
Copy link

KalleZ commented Nov 6, 2021

Describe the bug
The \Phalcon\Support\Collection\ReadOnly class (previously known as \Phalcon\Collection\ReadOnly) does not work with PHP 8.1's new read-only feature:

https://wiki.php.net/rfc/readonly_properties_v2

To Reproduce
https://3v4l.org/ioc85

Details

  • Phalcon version: Irrelevant
  • PHP Version: PHP 8.1
  • Operating System: Irrelevant
  • Installation type: Irrelevant
  • Zephir version (if any): Irrelevant
  • Server: Irrelevant
  • Other related info (Database, table schema): None
@KalleZ KalleZ added bug A bug report status: unverified Unverified labels Nov 6, 2021
@niden niden self-assigned this Nov 6, 2021
@niden niden added 5.0 The issues we want to solve in the 5.0 release status: medium Medium and removed status: unverified Unverified labels Nov 6, 2021
@niden niden mentioned this issue Nov 6, 2021
Closed
@niden niden linked a pull request Nov 6, 2021 that will close this issue
renamed support/collection/readonly to support/collection/readonlycol… #15768
Merged
5 tasks
@niden
Copy link
Sponsor Member

niden commented Nov 7, 2021

Resolved in #15768

@niden niden closed this as completed Nov 7, 2021
@niden niden added this to Implemented in Phalcon Roadmap Nov 7, 2021
@niden niden moved this from Implemented to Released in Phalcon Roadmap Nov 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@niden niden

Labels
5.0 The issues we want to solve in the 5.0 release bug A bug report status: medium Medium
Projects
Phalcon v5
Archived in project
Phalcon Roadmap
  
Released
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

renamed support/collection/readonly to support/collection/readonlycol…
2 participants
@KalleZ @niden