[NFR]: crypt->decode throws Warning

[destyk]

The current issue is related to the Phalcon\Encryption\Crypt module. It lies in the fact that if any random string that is less than 16 bytes long is passed to the decryption function, then PHP throws a Warning: openssl_decrypt(): the passed IV is only 2 bytes long, cipher expects an IV exactly 16 bytes long.

Example:

// service.php
$di->set('crypt', function () {
    $crypt = new Crypt();
    $crypt
        ->setKey('secretKey')
        ->useSigning(true);

    return $crypt;
}, true);

// ExampleController.php
// ...

$encryptStr = $this->crypt->encryptBase64('plain text');

// throws Warning
$input = $this->crypt->decryptBase64('123');

This problem is, of course, solved by disabling the display of warnings in the production environment. However, I would like to see in the future a function to check the encoded string for the number of bytes required by the cipher in use.

Example:

// ExampleController.php
// ...

$input = 'str data';
if ($this->crypt->isValidInputLength($input)) {
    echo 'input length is valid. You can try to decode';
} else {
    echo 'input length is NOT valid. Don\'t even try to decode';
}

Many thanks in advance and have a nice day! :)

[niden]

@destyk Thank you for reporting this. I will sort it out shortly.

[noone-silent]

Why using the complex error handler stuff? Because openssl_cipher_iv_length() raises a warning? Why not simply check with openssl_get_cipher_methods() if the cipher is supported?

[niden]

Why using the complex error handler stuff? Because openssl_cipher_iv_length() raises a warning? Why not simply check with openssl_get_cipher_methods() if the cipher is supported?

Yes that was the intent. Your solution is better and faster :)

[niden]

Why using the complex error handler stuff? Because openssl_cipher_iv_length() raises a warning? Why not simply check with openssl_get_cipher_methods() if the cipher is supported?

Actually looking at the code - and I forgot about this - the cipher is checked against the available ciphers so it will always be valid. I have simplified the code. Thank you @noone-silent

[niden]

Resolved in #15895

Thank you @destyk and @noone-silent