Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Phalcon\Mvc\Micro finish handler need typeof test #16240

Closed
yannux opened this issue Dec 8, 2022 · 1 comment · Fixed by #16241
Closed

Phalcon\Mvc\Micro finish handler need typeof test #16240

yannux opened this issue Dec 8, 2022 · 1 comment · Fixed by #16241
Assignees
Labels
5.0 The issues we want to solve in the 5.0 release bug A bug report status: medium Medium

Comments

@yannux
Copy link

yannux commented Dec 8, 2022

Phalcon version 5.1.2
Minor bug

Message

Phalcon\Mvc\Micro::handle(): instanceof expects an object instance

When checking finish handler there is no typof test

if finish instanceof MiddlewareInterface {

But for other handler like after there is a typeof === "object"
https://github.com/phalcon/cphalcon/blob/v5.1.2/phalcon/Mvc/Micro.zep#L615

It's seem the fix was missing with this commit 30379b6#diff-f935028249fa6ba82f53d50fcb058af22c3cec8db674d7b875292bd9b573669d

@niden niden self-assigned this Dec 8, 2022
@niden niden added bug A bug report status: medium Medium 5.0 The issues we want to solve in the 5.0 release labels Dec 8, 2022
@niden niden mentioned this issue Dec 8, 2022
5 tasks
@niden niden linked a pull request Dec 8, 2022 that will close this issue
5 tasks
@niden
Copy link
Sponsor Member

niden commented Dec 8, 2022

Resolved in #16241

Thank you @yannux

@niden niden closed this as completed Dec 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
5.0 The issues we want to solve in the 5.0 release bug A bug report status: medium Medium
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants