Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG]: \Phalcon\Cli\Router must be compatible with \Phalcon\Cli\RouterInterface #16551

Closed
jturbide opened this issue Mar 17, 2024 · 1 comment
Assignees
Labels
5.0 The issues we want to solve in the 5.0 release bug A bug report status: medium Medium

Comments

@jturbide
Copy link
Sponsor Contributor

jturbide commented Mar 17, 2024

Describe the bug

  • The \Phalcon\Cli\Router must be compatible with \Phalcon\Cli\RouterInterface
  • The \Phalcon\Cli\Router should implements \Phalcon\Cli\RouterInterface

To Reproduce

class Router extends \Phalcon\Cli\Router implements \Phalcon\Cli\RouterInterface
{
}

Will result in:

  • Fatal error: Declaration of Phalcon\Cli\Router::getRouteById($id) must be compatible with Phalcon\Cli\RouterInterface::getRouteById($id): Phalcon\Cli\Router\RouteInterface
@jturbide jturbide added bug A bug report status: unverified Unverified labels Mar 17, 2024
@niden niden mentioned this issue Mar 19, 2024
5 tasks
@niden niden self-assigned this Mar 19, 2024
@niden niden added status: medium Medium 5.0 The issues we want to solve in the 5.0 release and removed status: unverified Unverified labels Mar 19, 2024
@niden
Copy link
Sponsor Member

niden commented Mar 19, 2024

This has been resolved in #16554

Thank you @jturbide

@niden niden closed this as completed Mar 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
5.0 The issues we want to solve in the 5.0 release bug A bug report status: medium Medium
Projects
Status: Implemented
Development

No branches or pull requests

2 participants