[BUG] PHP Error after \Phalcon\Mvc\Model\MetaData::reset()

[fangface]

Using Phalcon 1.2.4 I am getting PHP errors after making use of the MetaData::reset() call to force metadata to be reloaded.

$connection = new \Phalcon\Db\Adapter\Pdo\Mysql(array(
    'host' => 'localhost',
    'username' => 'user',
    'password' => 'password',
    'dbname' => 'test_company_1',
));

$di->set('companyDb', $connection, true);

$robot = \Models\Robots::findFirst(1);
print_r($robot->toArray());

The above works fine and the current robot is displayed

Now if I need to connect to another database (for the sake of argument lets say there are thousands of databases to iterate through, so setting up a seperate $di service and seperate models for each is not practical so I want to reuse the the same models and so the same connection service and table names

$connection = new \Phalcon\Db\Adapter\Pdo\Mysql(array(
    'host' => 'localhost',
    'username' => 'user',
    'password' => 'password',
    'dbname' => 'test_company_2',
));

$di->set('companyDb', $connection, true);

The table structures could be slightly out of sync with new fields etc so I need to ensure the corrent metadata is loaded again

$di->get('modelsMetadata')->reset();

Now when I run the following it works and the new structure is displayed.

$robot = \Models\Robots::findFirst(1);
print_r($robot->toArray());

But both the findFirst() and toArray() methods now generate a PHP error;
Notice: Undefined index: models\robots in ...

Please note that within the Robots.php class file I make use of the following to ensure that any changes to the connection service are picked up

public function getReadConnection()
{
    return $this->getDI()->get($this->getReadConnectionService());
}

I can also generate the same PHP error without changing database connections if the Metadata reset option is used between method calls.

$robot = \Models\Robots::findFirst(1);
print_r($robot->toArray());

$di->get('modelsMetadata')->reset();

$robot = \Models\Robots::findFirst(1);
print_r($robot->toArray());

[ghost]

Worked for me in 1.2.5:

Array
(
    [id] => 1
    [name] => Robotina
    [type] => mechanical
    [year] => 1972
)
Array
(
    [id] => 1
    [name] => Robotina
    [type] => mechanical
    [year] => 1972
)

However, could you please try this:

-$di->get('modelsMetadata')->reset();
+$di->getShared('modelsMetadata')->reset();

?

[fangface]

I have tried with getShared() and that made no difference. I have also now tried both options using 1.2.5 and continue to get the same error.

Please note I am using the following to see the error;

error_reporting(E_ALL);
ini_set('display_errors', 1);

[ghost]

Could you please show more code?

With this:

<?php

error_reporting(E_ALL | E_STRICT);

require __DIR__ . '/models/Robots.php';

$di = new Phalcon\DI();

$di->set('modelsManager', function(){
        return new Phalcon\Mvc\Model\Manager();
});

$di->set('modelsMetadata', function(){
        return new Phalcon\Mvc\Model\Metadata\Memory();
});

$di->set('db', function(){
        require __DIR__ . '/config.db.php';
        return new Phalcon\Db\Adapter\Pdo\Mysql($configMysql);
});

$robot = Models\Robots::findFirst(1);
print_r($robot->toArray());

$di->get('modelsMetadata')->reset();

$robot = Models\Robots::findFirst(1);
print_r($robot->toArray());
?>

I am unable to reproduce the issue.

[fangface]

Ok that works by itself for me as well, so after digging deeper here is how to alter it slightly to trigger the notice.

<?php

error_reporting(E_ALL | E_STRICT);
ini_set('display_errors', '1');

Phalcon\Mvc\Model::setup(array(
    'columnRenaming' => false,
));

require __DIR__ . '/models/Robots.php';

$di = new Phalcon\DI\FactoryDefault();

$di->set('db', function(){
        require __DIR__ . '/config.db.php';
        return new Phalcon\Db\Adapter\Pdo\Mysql($configMysql);
});

$robot = Models\Robots::findFirst(1);
print_r($robot->toArray());

$di->get('modelsMetadata')->reset();

$robot = Models\Robots::findFirst(1);
print_r($robot->toArray());
?>

Please note the use of BOTH of the following is required to trigger the notice;

$di = new Phalcon\DI\FactoryDefault();

and;

Phalcon\Mvc\Model::setup(array(
    'columnRenaming' => false,
));

[ghost]

Fix submitted (#1952)