Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Phalcon\Dispatcher uses _handleException only when the event manager is defined #1953

Closed
iby opened this issue Feb 1, 2014 · 2 comments
Closed

Comments

@iby
Copy link
Contributor

iby commented Feb 1, 2014

The logic seems to be along the lines with _throwDispatchException, but the method is called only if the event manager is defined #L859. It would be actually nice to have access to the internal method to be able to implement the handling logic within the dispatcher.

Decoupling it into a separate event listener of a separate event manager might not always be desired. I personally want to keep the critical logic with the dispatcher and not be able to simply unset the event manager to loose it.

@ghost
Copy link

ghost commented Feb 25, 2014

Done.

@iby
Copy link
Contributor Author

iby commented Feb 25, 2014

👍

@iby iby closed this as completed Feb 25, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants