Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

\Phalcon\Tag : element attribute consistency [Cosmetic][Standards] #61

Closed
niden opened this issue Sep 8, 2012 · 4 comments
Closed

\Phalcon\Tag : element attribute consistency [Cosmetic][Standards] #61

niden opened this issue Sep 8, 2012 · 4 comments
Assignees
Labels
bug A bug report status: low Low
Milestone

Comments

@niden
Copy link
Sponsor Member

niden commented Sep 8, 2012

In order to keep a standard way of how all helpers work I would like to propose/and see the following generation of tags from all helpers (in this order

type (if input)
src
id
name
value
class
(others)

So effectively an Tag::image will generate

<img src='....' id='abc' class='active' />
<input type='password' id='passone' name='mypass' class='' />
<input type='text' id='textone' name='mytext' value='test' class='' />

Also as far as consistency is concerned, if a tag does not have a closing tag like , there must be a space followed by a slash and the greater than at closing. Example

<img src='....' id='abc' class='active' />

For elements that do not "need" the />, no space is necessary.

@niden
Copy link
Sponsor Member Author

niden commented Sep 12, 2012

This has been addressed.

@niden niden closed this as completed Sep 12, 2012
@ghost ghost assigned niden Sep 12, 2012
@ghost
Copy link

ghost commented Oct 4, 2013

Looks like this has been broken :-(

@ghost
Copy link

ghost commented Oct 4, 2013

The current order:

(type, for), (src, href, action), id, name, value, class

Exceptions:

  • link rel="stylesheet"
  • option selected="" value=""

@niden
Copy link
Sponsor Member Author

niden commented Oct 4, 2013

Thanks!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug A bug report status: low Low
Projects
None yet
Development

No branches or pull requests

1 participant