Adding Helper To Mock Result Sets In Testing #720
Conversation
| * User: Charles.Martin | ||
| * Date: 12/13/2016 | ||
| * Time: 12:41 PM | ||
| */ |
There was a problem hiding this comment.
Could you please use proper DocBlock or remove this at all
| * Time: 12:41 PM | ||
| */ | ||
|
|
||
| namespace unit\Test\Traits; |
There was a problem hiding this comment.
unit\Test\Traits => Unit\Test\Traits
There was a problem hiding this comment.
After double checking this (comparing other files), I believe this should actually be 'Phalcon\Test\Test\Traits'?
| use ResultSet; | ||
|
|
||
| /** @var \Phalcon\Test\Traits\ResultSet */ | ||
| protected $testSubject = NULL; |
| } | ||
|
|
||
| public function testCanMockResultSet() { | ||
| $mockModel = $this->getMockBuilder('\Phalcon\Mvc\Model') |
There was a problem hiding this comment.
use Phalcon\Mvc\Model
$mockModel = $this->getMockBuilder(Model:class)| } | ||
|
|
||
| public function testCanUseOtherResultSetClasses() { | ||
| $mockResultset = $this->mockResultset([], '\Phalcon\Mvc\Model\Resultset\Simple'); |
There was a problem hiding this comment.
Phalcon\Mvc\Model\Resultset\Simple;
$mockResultset = $this->mockResultset([], Simple::class);| $this->assertSame($mockData, $mockResultSet->toArray()); | ||
| } | ||
|
|
||
| public function testCanMockEmptyResultSet() { |
There was a problem hiding this comment.
public function testCanMockEmptyResultSet() {
=>
public function testCanMockEmptyResultSet()
{
| @@ -57,7 +57,9 @@ protected function _before() | |||
| */ | |||
| protected function _after() | |||
| { | |||
| $this->cleanup(); | |||
| if (extension_loaded('aerospike')) { | |||
| $this->cleanup(); | |||
| * | ||
| * @return \PHPUnit_Framework_MockObject_MockObject|\Phalcon\Mvc\Model\Resultset|\Phalcon\Mvc\Model\ResultsetInterface | ||
| */ | ||
| public function mockResultSet(array $dataSet, $className = '\Phalcon\Mvc\Model\Resultset') |
There was a problem hiding this comment.
use Phalcon\Mvc\Model\Resultset;
public function mockResultSet(array $dataSet, $className = Resultset::class)
{
…sion was already skipped in _before.
|
...Apparently I made the changes but never finished them or pushed them up...go figure...oops. |
|
@Fenikkusu Could you please rebase on 3.1.x branch |
|
The |
|
Updated, though it looks like the dump.sql may be out of date. Running Codeception locally is resulting in errors from EagerLoading and Prefixing. |
|
Ignore my previous comment regarding the dump.sql - DB wasn't populated. |
Hello!
This pull request affects the following components: (please check boxes)
In raising this pull request, I confirm the following (please check boxes):
Small description of change:
I've added a trait for mocking a basic Result set. This comes in handy when doing unit tests and I don't want to have to actually connect to the DB to do so.
Thanks