#76 - Refactor batchInsert() method

phalcon · Mar 28, 2020 · 0739d36 · 0739d36
1 parent dbc07ae
commit 0739d36
Show file tree

Hide file tree

Showing 5 changed files with 2,546 additions and 7 deletions.
diff --git a/src/Mvc/Model/Migration.php b/src/Mvc/Model/Migration.php
@@ -710,23 +710,29 @@ public function batchInsert(string $tableName, $fields)
     {
         $migrationData = self::$migrationPath . $this->version . '/' . $tableName . '.dat';
         if (!file_exists($migrationData)) {
-            return; // nothing to do
+            return;
         }
 
         self::$connection->begin();
-        self::$connection->delete($tableName);
 
         $batchHandler = fopen($migrationData, 'r');
         while (($line = fgetcsv($batchHandler)) !== false) {
             $values = array_map(
                 function ($value) {
-                    return null === $value ? null : stripslashes($value);
+                    if (null === $value) {
+                        return null;
+                    }
+
+                    if ($value === 'NULL') {
+                        return null;
+                    }
+
+                    return stripslashes($value);
                 },
                 $line
             );
 
-            $nullify = new Nullify();
-            self::$connection->insert($tableName, $nullify($values), $fields);
+            self::$connection->insert($tableName, $values, $fields);
             unset($line);
         }