Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ISSUE-111, 112: Fixed types and indexes definition on pgsql adaper #116

Merged

Conversation

BeMySlaveDarlin
Copy link
Contributor

@BeMySlaveDarlin BeMySlaveDarlin commented May 5, 2021

Issue: #111
Fixed:

  • Using type double column definition isn't supported by Postgresql adapter, so replaced by float type

Issue: #112
Fixed:

  • Adapter type detection now case insensitive
  • Adapter::describeIndexes() now have index types description
  • Using Postgresql adapter now doesn't disables indexes definition generating

@BeMySlaveDarlin BeMySlaveDarlin changed the title ISSUE-111: Replaced pgsql unsupported double type to supported float ISSUE-111, 112: Fixed types and indexes definition on pgsql adaper May 5, 2021
@BeMySlaveDarlin BeMySlaveDarlin force-pushed the fix/ISSUE-111-pgsql-column-type branch 2 times, most recently from 1b38b83 to 7f034ef Compare May 5, 2021 00:25
@codecov
Copy link

codecov bot commented May 5, 2021

Codecov Report

Merging #116 (b30018d) into 2.0.x (171fe6d) will increase coverage by 3.69%.
The diff coverage is 64.70%.

@@             Coverage Diff              @@
##              2.0.x     #116      +/-   ##
============================================
+ Coverage     44.17%   47.87%   +3.69%     
- Complexity      507      523      +16     
============================================
  Files            23       23              
  Lines          1365     1385      +20     
============================================
+ Hits            603      663      +60     
+ Misses          762      722      -40     

@BeMySlaveDarlin BeMySlaveDarlin force-pushed the fix/ISSUE-111-pgsql-column-type branch 4 times, most recently from 991626f to fc08ab3 Compare May 5, 2021 01:07
src/Utils.php Outdated Show resolved Hide resolved
src/Utils.php Outdated Show resolved Hide resolved
@BeMySlaveDarlin BeMySlaveDarlin force-pushed the fix/ISSUE-111-pgsql-column-type branch from fc08ab3 to cb3f6d5 Compare May 6, 2021 20:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants