Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#141 - Change RuntimeException throw to output warning message #142

Merged
merged 2 commits into from
May 3, 2023
Merged

#141 - Change RuntimeException throw to output warning message #142

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5145bb8
#141 - Change `RuntimeException` throw to output warning message
Jeckerson May 2, 2023
6058786
#141 - Comment unworked line
Jeckerson May 2, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/Db/FieldDefinition.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -132,7 +132,7 @@ public function isChangedName(FieldDefinition $comparingFieldDefinition): bool
public function isChangedData(FieldDefinition $comparingFieldDefinition): bool
{
$paramsToCheck = get_class_methods(ColumnInterface::class);
unset($paramsToCheck['getName']);
//unset($paramsToCheck['getName']); // TODO: Validate if this even needed.

$comparingFieldColumn = $comparingFieldDefinition->getColumn();
foreach ($paramsToCheck as $method) {
Expand Down
3 changes: 2 additions & 1 deletion src/Migrations.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -270,7 +270,8 @@
join(PHP_EOL, $migrationsDirList) :
$migrationsDirList;

throw new RuntimeException('Migrations were not found at:' . PHP_EOL . PHP_EOL . $migrationsPath);
echo Color::error('Migrations were not found at:' . $migrationsPath, 'Warning: ');
return;

Check warning on line 274 in src/Migrations.php

View check run for this annotation

Codecov / codecov/patch

src/Migrations.php#L273-L274 

Added lines #L273 - L274 were not covered by tests
}

// Set default final version
Expand Down
Loading