Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#151 - Shift to PHP8.0 #152

Merged
merged 24 commits into from
Apr 15, 2024
Merged

#151 - Shift to PHP8.0 #152

merged 24 commits into from
Apr 15, 2024

Conversation

Jeckerson
Copy link
Member

@Jeckerson Jeckerson commented Apr 13, 2024

Hello!

  • Type: code quality

In raising this pull request, I confirm the following (please check boxes):

  • I have read and understood the Contributing Guidelines
  • I have checked that another pull request for this purpose does not exist
  • I wrote some tests for this PR

Thanks

@Jeckerson Jeckerson self-assigned this Apr 13, 2024
@Jeckerson Jeckerson requested a review from niden April 13, 2024 22:47
@Jeckerson Jeckerson marked this pull request as draft April 13, 2024 22:53
Copy link

codecov bot commented Apr 14, 2024

Codecov Report

Merging #152 (7c1b2db) into master (7dfa9d7) will increase coverage by 5.11%.
The diff coverage is 91.80%.

Additional details and impacted files
@@             Coverage Diff              @@
##             master     #152      +/-   ##
============================================
+ Coverage     56.79%   61.90%   +5.11%     
+ Complexity      545      497      -48     
============================================
  Files            21       18       -3     
  Lines          1509     1457      -52     
============================================
+ Hits            857      902      +45     
+ Misses          652      555      -97     

@Jeckerson Jeckerson marked this pull request as ready for review April 14, 2024 21:45
# Conflicts:
#	src/Migration/Action/Generate.php
@Jeckerson Jeckerson linked an issue Apr 14, 2024 that may be closed by this pull request
@Jeckerson Jeckerson merged commit f5791f7 into master Apr 15, 2024
23 of 24 checks passed
@Jeckerson Jeckerson deleted the #151-php8.0-refactor branch April 15, 2024 07:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Shift minimum PHP support to v8.0
2 participants