Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#58 - Set 'version' column in phalcon migrations as primary #62

Merged
merged 2 commits into from
Feb 23, 2020
Merged

#58 - Set 'version' column in phalcon migrations as primary #62

merged 2 commits into from
Feb 23, 2020

Conversation

Jeckerson
Copy link
Member

Issue: #58

@Jeckerson Jeckerson added this to the 1.2.x milestone Feb 23, 2020
@Jeckerson Jeckerson self-assigned this Feb 23, 2020
@codecov
Copy link

codecov bot commented Feb 23, 2020 •
edited
Loading

Codecov Report

Merging #62 into master will decrease coverage by 0.03%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master      #62      +/-   ##
============================================
- Coverage      35.4%   35.36%   -0.04%     
  Complexity      617      617              
============================================
  Files            26       26              
  Lines          1644     1643       -1     
============================================
- Hits            582      581       -1     
  Misses         1062     1062
Impacted Files Coverage Δ Complexity Δ
src/Migrations.php 55.15% <ø> (-0.14%) 115 <0> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b16acc0...e74df92. Read the comment docs.

@Jeckerson Jeckerson merged commit f12f112 into master Feb 23, 2020
@Jeckerson Jeckerson added this to Implemented in Phalcon Roadmap via automation Feb 23, 2020
@Jeckerson Jeckerson deleted the #58-pk-version-phalcon-migrations branch February 23, 2020 13:05
@Jeckerson Jeckerson mentioned this pull request Feb 23, 2020
Closed
@niden niden moved this from Implemented to Released in Phalcon Roadmap Mar 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ruudboon ruudboon ruudboon approved these changes

@niden niden Awaiting requested review from niden

@sergeyklay sergeyklay Awaiting requested review from sergeyklay

Assignees

@Jeckerson Jeckerson

Labels
enhancement New feature or request MySQL PostgreSQL SQLite
Projects
Phalcon v5
Archived in project
Phalcon Roadmap
  
Released
Milestone
1.2.x
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Jeckerson @ruudboon