Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade for Phalcon V5 and PHP 8 #1535

Merged
merged 16 commits into from
Aug 29, 2023
Merged

Upgrade for Phalcon V5 and PHP 8 #1535

merged 16 commits into from
Aug 29, 2023

Conversation

escribiendocodigo
Copy link
Contributor

Hello!

Upgrade Phalcon Devtools to work with Phalcon V5, Phalcon Migration V3 and PHP 8

In raising this pull request, I confirm the following (please check boxes):

  • I have read and understood the Contributing Guidelines
  • I have checked that another pull request for this purpose does not exist
  • I wrote some tests for this PR

Upgrade Guide

Thanks

@codecov
Copy link

codecov bot commented Jul 19, 2023

Codecov Report

Merging #1535 (a0473a7) into 5.0.x (e3f1aeb) will increase coverage by 1.11%.
The diff coverage is 0.00%.

Additional details and impacted files
@@           Coverage Diff            @@
##           5.0.x   #1535      +/-   ##
========================================
+ Coverage   3.29%   4.40%   +1.11%     
========================================
  Files        111      82      -29     
  Lines       5101    3995    -1106     
========================================
+ Hits         168     176       +8     
+ Misses      4933    3819    -1114     

Copy link
Contributor

@rudiservo rudiservo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The works checks out, I have tested and generated, the only that is missing is the changelog entry.
I think it can be added after.

@niden niden merged commit 2e16ea6 into phalcon:5.0.x Aug 29, 2023
6 of 7 checks passed
@niden
Copy link
Sponsor Member

niden commented Aug 29, 2023

Thank you @escribiendocodigo !!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Released
Development

Successfully merging this pull request may close these issues.

None yet

3 participants