-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(options): add support for different manifest input than bundle.dest #2
Conversation
Hey @msc117 👋 thanks for the PR. Can you describe a scenario when someone might need to use a different key in the manifest other than the original bundle destination? |
In my use case, I'm using |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 Looks good to me. Only minor point is changing the property name to something more specific.
README.md
Outdated
@@ -85,6 +85,15 @@ Example manifest: | |||
} | |||
``` | |||
|
|||
### input |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As input
is quite an ambiguous property name, especially in the context of Rollup. Can you change this to something more specific, such as manifestInput
, manifestKey
or manifestProperty
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Going to switch it to manifestKey
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
README.md
Outdated
Default: `bundle.dest` | ||
Required: `false` | ||
|
||
The name of your filename intro used in creating manifest. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Change to something along the lines of: "The filename used as the input key in the generated manifest map."
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated
Thanks for your help! |
I've now published this as |
Thanks! |
No description provided.