Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Also emit PhanPluginDuplicateConditionalNullCoalescing for X !== null ? X : Y and !is_null(X) #2691

Closed
TysonAndre opened this issue Apr 26, 2019 · 0 comments · Fixed by #2702
Closed

Also emit PhanPluginDuplicateConditionalNullCoalescing for X !== null ? X : Y and !is_null(X) #2691

TysonAndre opened this issue Apr 26, 2019 · 0 comments · Fixed by #2702
Assignees
@TysonAndre
Labels
enhancement This improves the quality of Phan's analysis of a codebase probably easy A good ticket to start with. Also see https://github.com/phan/phan/wiki/Developer%27s-Guide-To-Phan

Comments

@TysonAndre
Copy link
Member

Currently, it just checks isset in .phan/plugins/DuplicateExpressionPlugin.php
@TysonAndre TysonAndre added enhancement This improves the quality of Phan's analysis of a codebase probably easy A good ticket to start with. Also see https://github.com/phan/phan/wiki/Developer%27s-Guide-To-Phan labels Apr 26, 2019
@TysonAndre TysonAndre self-assigned this May 1, 2019
TysonAndre added a commit to TysonAndre/phan that referenced this issue May 1, 2019
@TysonAndre
Add more checks to DuplicateExpressionPlugin
13f3020 
Fixes phan#2691
@TysonAndre TysonAndre mentioned this issue May 1, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@TysonAndre TysonAndre

Labels
enhancement This improves the quality of Phan's analysis of a codebase probably easy A good ticket to start with. Also see https://github.com/phan/phan/wiki/Developer%27s-Guide-To-Phan
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add more checks to DuplicateExpressionPlugin TysonAndre/phan
1 participant
@TysonAndre